improvement: fdi tooth chart selection modes polished. bugs related to teeth selecyion fixed.

backend/src/modules/cases/lab-case-task.generator.spec.ts

@@ -172,7 +172,7 @@ describe('generateLabCaseTasks', () => {
     expect(stepCodes).toContain('printer_resin');
   });
 
-  it('keeps separate selection groups with the same prosthesis type as separate task sets', async () => {
+  it('merges teeth with the same prosthesis type across selection groups', async () => {
     const pfmSteps = stepsFromSeed('pfm_crown');
     const { tx, created } = buildMockTx({
       toothProsthesisRows: [
@@ -198,21 +198,13 @@ describe('generateLabCaseTasks', () => {
       prosthesisTypes: [{ code: 'pfm_crown', steps: pfmSteps }],
     });
 
-    const count = await generateLabCaseTasks(tx as never, 'lab-case-split', 'en');
-    expect(count).toBe(pfmSteps.length * 2);
-    const rows = created as Array<{
-      teeth: string[];
-      selectionGroupId: string;
-      prosthesisTypeCode: string;
-    }>;
-    const connected = rows.filter((r) => r.selectionGroupId === 'connected-1');
-    const single = rows.filter((r) => r.selectionGroupId === 'single-21');
-    expect(connected).toHaveLength(pfmSteps.length);
-    expect(single).toHaveLength(pfmSteps.length);
-    expect(connected.every((r) => JSON.stringify(r.teeth) === JSON.stringify(['14', '15']))).toBe(
+    const count = await generateLabCaseTasks(tx as never, 'lab-case-merge', 'en');
+    expect(count).toBe(pfmSteps.length);
+    const rows = created as Array<{ teeth: string[]; prosthesisTypeCode: string }>;
+    expect(rows).toHaveLength(pfmSteps.length);
+    expect(rows.every((r) => JSON.stringify(r.teeth) === JSON.stringify(['14', '15', '21']))).toBe(
       true,
     );
-    expect(single.every((r) => JSON.stringify(r.teeth) === JSON.stringify(['21']))).toBe(true);
   });
 
   it('skips generation when tasks already exist', async () => {

backend/src/modules/cases/lab-case-task.generator.ts

@@ -58,8 +58,9 @@ export async function generateLabCaseTasks(
 
   const stepLabels = await resolveStepLabels(tx, allStepCodes, locale);
 
-  // Group by selection group + prosthesis type so connected spans stay one task set,
-  // and separate singles stay separate even with the same prosthesis type.
+  // Merge all teeth that share the same prosthesis type on a detail into one
+  // task set (pre–selection-group behavior). selectionGroupId is stored for
+  // UI/history only — not part of the grouping key.
   const groups = new Map<
     string,
     {
@@ -72,10 +73,8 @@ export async function generateLabCaseTasks(
   >();
 
   for (const row of toothProsthesisRows) {
-    const selectionGroupId =
-      row.selectionGroupId?.trim() ||
-      fallbackGroupIdForTooth(row.detail.toothSelectionGroups, row.tooth, row.prosthesisTypeCode);
-    const key = `${row.treatmentDetailId}::${selectionGroupId}::${row.prosthesisTypeCode}`;
+    const key = `${row.treatmentDetailId}::${row.prosthesisTypeCode}`;
+    const selectionGroupId = row.selectionGroupId?.trim() || '';
     const group = groups.get(key) ?? {
       treatmentDetailId: row.treatmentDetailId,
       treatmentType: row.detail.treatmentType,
@@ -83,6 +82,10 @@ export async function generateLabCaseTasks(
       selectionGroupId,
       teeth: [],
     };
+    // Keep first non-empty selectionGroupId for persistence; grouping ignores it.
+    if (!group.selectionGroupId && selectionGroupId) {
+      group.selectionGroupId = selectionGroupId;
+    }
     group.teeth.push(row.tooth);
     groups.set(key, group);
   }
@@ -121,24 +124,6 @@ export async function generateLabCaseTasks(
   return taskRows.length;
 }
 
-function fallbackGroupIdForTooth(
-  toothSelectionGroups: unknown,
-  tooth: string,
-  prosthesisTypeCode: string,
-): string {
-  if (Array.isArray(toothSelectionGroups)) {
-    for (const row of toothSelectionGroups) {
-      if (!row || typeof row !== 'object') continue;
-      const rec = row as { groupId?: unknown; teeth?: unknown };
-      if (typeof rec.groupId !== 'string') continue;
-      if (Array.isArray(rec.teeth) && rec.teeth.includes(tooth)) {
-        return rec.groupId;
-      }
-    }
-  }
-  return `legacy-${prosthesisTypeCode}`;
-}
-
 function sortTeeth(teeth: string[]): string[] {
   return [...new Set(teeth)].sort((a, b) => {
     const na = Number(a);