Amin Mousavi
dc10d8dbe3
I wrote 731 comment lines on this branch against 4,530 lines of code — 14%, where the rest of the repo runs at 1.8%. CLAUDE.md asks for code that reads like its surroundings, and this did not. Removed by genre rather than by taste: - restating the code, e.g. "JS getUTCDay() numbering: Sunday = 0" above the map that literally shows it, and a docblock on startOfWeek explaining that it returns the start of the week; - narrating history — "this used to rebuild the whole map", "left the bar recording forever" — which the commit message and git blame already carry; - saying the same thing in several places: the "cannot record is not a denied microphone" reason appeared three times in one file, and the "aborting stops a per-minute metered call" reason across three files. Each now lives once, where the behaviour it explains lives; - defending decisions nobody would question, like why toLatinDigits is its own module; - over-explaining defensive branches, three separate comments to distinguish null from missing-kind from unrecognised-kind. What stays is what the code cannot say: the patient-right convention in toFdi, whose failure mode is a valid code for the wrong tooth; the "this"-vs-"next" week anchoring; StrictMode re-arming mountedRef; Safari accepting no mimeType hint; and the invariants whose violation already cost a bug — the body parser's middleware ordering and the dispatch panel's auto-fill rules. Comments only. The diff contains no non-comment line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
77 lines
2.2 KiB
TypeScript
77 lines
2.2 KiB
TypeScript
/** Convert an absolute instant into weekday + minute-of-day in an IANA time zone. */
|
|
|
|
const JS_WEEKDAY: Record<string, number> = {
|
|
Sun: 0,
|
|
Mon: 1,
|
|
Tue: 2,
|
|
Wed: 3,
|
|
Thu: 4,
|
|
Fri: 5,
|
|
Sat: 6,
|
|
};
|
|
|
|
export function isValidIanaTimeZone(timeZone: string): boolean {
|
|
if (!timeZone || timeZone.length > 64) {
|
|
return false;
|
|
}
|
|
try {
|
|
Intl.DateTimeFormat('en-US', { timeZone }).format(new Date(0));
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
export function zonedWeekdayAndMinutes(
|
|
date: Date,
|
|
timeZone: string,
|
|
): { jsWeekday: number; minuteOfDay: number } {
|
|
const parts = new Intl.DateTimeFormat('en-US', {
|
|
timeZone,
|
|
weekday: 'short',
|
|
hour: '2-digit',
|
|
minute: '2-digit',
|
|
hourCycle: 'h23',
|
|
}).formatToParts(date);
|
|
|
|
const weekdayToken = parts.find((p) => p.type === 'weekday')?.value ?? 'Sun';
|
|
let hour = Number(parts.find((p) => p.type === 'hour')?.value ?? '0');
|
|
const minute = Number(parts.find((p) => p.type === 'minute')?.value ?? '0');
|
|
if (hour === 24) {
|
|
hour = 0;
|
|
}
|
|
|
|
return {
|
|
jsWeekday: JS_WEEKDAY[weekdayToken] ?? 0,
|
|
minuteOfDay: hour * 60 + minute,
|
|
};
|
|
}
|
|
|
|
/** Weekday of a YYYY-MM-DD civil date (Gregorian; same worldwide). */
|
|
export function civilDateJsWeekday(isoDate: string): number {
|
|
const [y, m, d] = isoDate.split('-').map(Number);
|
|
const utcNoon = new Date(Date.UTC(y, m - 1, d, 12, 0, 0, 0));
|
|
return utcNoon.getUTCDay();
|
|
}
|
|
|
|
/**
|
|
* Today's civil date (`YYYY-MM-DD`) in an IANA zone, so the server derives "today" from a
|
|
* client-supplied *zone* rather than trusting a client-supplied date.
|
|
*/
|
|
export function civilDateInZone(date: Date, timeZone: string): string {
|
|
// Intl throws RangeError on an unknown zone and this takes a client-supplied string;
|
|
// callers validate first, this is the backstop.
|
|
const zone = isValidIanaTimeZone(timeZone) ? timeZone : 'UTC';
|
|
const parts = new Intl.DateTimeFormat('en-CA', {
|
|
timeZone: zone,
|
|
year: 'numeric',
|
|
month: '2-digit',
|
|
day: '2-digit',
|
|
}).formatToParts(date);
|
|
|
|
const year = parts.find((p) => p.type === 'year')?.value ?? '1970';
|
|
const month = parts.find((p) => p.type === 'month')?.value ?? '01';
|
|
const day = parts.find((p) => p.type === 'day')?.value ?? '01';
|
|
return `${year}-${month}-${day}`;
|
|
}
|