Amin Mousavi
b5560b2f6b
I wrote 731 comment lines on this branch against 4,530 lines of code — 14%, where the rest of the repo runs at 1.8%. CLAUDE.md asks for code that reads like its surroundings, and this did not. Removed by genre rather than by taste: - restating the code, e.g. "JS getUTCDay() numbering: Sunday = 0" above the map that literally shows it, and a docblock on startOfWeek explaining that it returns the start of the week; - narrating history — "this used to rebuild the whole map", "left the bar recording forever" — which the commit message and git blame already carry; - saying the same thing in several places: the "cannot record is not a denied microphone" reason appeared three times in one file, and the "aborting stops a per-minute metered call" reason across three files. Each now lives once, where the behaviour it explains lives; - defending decisions nobody would question, like why toLatinDigits is its own module; - over-explaining defensive branches, three separate comments to distinguish null from missing-kind from unrecognised-kind. What stays is what the code cannot say: the patient-right convention in toFdi, whose failure mode is a valid code for the wrong tooth; the "this"-vs-"next" week anchoring; StrictMode re-arming mountedRef; Safari accepting no mimeType hint; and the invariants whose violation already cost a bug — the body parser's middleware ordering and the dispatch panel's auto-fill rules. Comments only. The diff contains no non-comment line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
61 lines
2.3 KiB
TypeScript
61 lines
2.3 KiB
TypeScript
/** Containers the backend accepts, in the order we prefer to record them. */
|
|
const PREFERRED_MIME_TYPES = [
|
|
'audio/webm;codecs=opus',
|
|
'audio/webm',
|
|
'audio/mp4',
|
|
'audio/aac',
|
|
'audio/ogg;codecs=opus',
|
|
'audio/ogg',
|
|
] as const;
|
|
|
|
/**
|
|
* Pick a container this browser can record AND the backend accepts. Chrome and Android give
|
|
* webm/opus, Safari and iPad mp4/aac; both go to the vendor unmodified, so there is no
|
|
* transcode step and the list is an intersection, not a preference.
|
|
*/
|
|
export function pickRecordingMimeType(): string | null {
|
|
if (typeof MediaRecorder === 'undefined') return null;
|
|
if (typeof MediaRecorder.isTypeSupported !== 'function') {
|
|
// Safari <14.1 shipped MediaRecorder without the feature check; let it choose.
|
|
return '';
|
|
}
|
|
for (const type of PREFERRED_MIME_TYPES) {
|
|
if (MediaRecorder.isTypeSupported(type)) return type;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/** `audio/webm;codecs=opus` → `webm`, which is what the API's `format` field wants. */
|
|
export function mimeTypeToFormat(mimeType: string): string {
|
|
const base = mimeType.split(';')[0]?.trim().toLowerCase() ?? '';
|
|
const subtype = base.startsWith('audio/') ? base.slice('audio/'.length) : base;
|
|
// Safari/iOS records `audio/mp4`, but the transcription endpoint's documented container
|
|
// list names m4a, not mp4. Same container; send the name the vendor documents, so iPad
|
|
// recordings do not fail while Chrome's webm works.
|
|
if (subtype === 'x-m4a' || subtype === 'm4a' || subtype === 'mp4') return 'm4a';
|
|
if (subtype === 'mpeg') return 'mp3';
|
|
return subtype || 'webm';
|
|
}
|
|
|
|
/** Blob → base64 without the `data:` prefix, which the API does not want. */
|
|
export async function blobToBase64(blob: Blob): Promise<string> {
|
|
const buffer = await blob.arrayBuffer();
|
|
let binary = '';
|
|
const bytes = new Uint8Array(buffer);
|
|
// Chunked to avoid blowing the argument limit on a two-minute recording.
|
|
const chunkSize = 0x8000;
|
|
for (let i = 0; i < bytes.length; i += chunkSize) {
|
|
binary += String.fromCharCode(...bytes.subarray(i, i + chunkSize));
|
|
}
|
|
return btoa(binary);
|
|
}
|
|
|
|
export function isMediaRecorderSupported(): boolean {
|
|
return (
|
|
typeof window !== 'undefined' &&
|
|
typeof MediaRecorder !== 'undefined' &&
|
|
typeof navigator !== 'undefined' &&
|
|
Boolean(navigator.mediaDevices?.getUserMedia)
|
|
);
|
|
}
|